Skip to content

Fix drawer content not expanding properly#7636

Merged
deleonio merged 2 commits intorelease/2from
7487-fix-drawer-slot-style
May 7, 2025
Merged

Fix drawer content not expanding properly#7636
deleonio merged 2 commits intorelease/2from
7487-fix-drawer-slot-style

Conversation

@anicyne
Copy link
Copy Markdown
Contributor

@anicyne anicyne commented May 5, 2025 •
edited
Loading

Refs: #7487

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@anicyne anicyne linked an issue May 5, 2025 that may be closed by this pull request
Drawer - Slot muss maximale Höhe bzw. Breite bekommen #7487
Closed
2 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 5, 2025 •
edited
Loading

Netlify Draft Deployment
URL:
Logs:

@deleonio deleonio added the v2 label May 6, 2025
deleonio
deleonio requested changes May 6, 2025
View reviewed changes
Comment thread packages/components/src/components/drawer/style.scss Outdated
deleonio
deleonio requested changes May 6, 2025
View reviewed changes
Comment thread packages/components/src/components/drawer/style.scss Outdated
@anicyne anicyne force-pushed the 7487-fix-drawer-slot-style branch from 0f9466d to 70a7e45 Compare May 6, 2025 07:27
@anicyne anicyne requested a review from deleonio May 6, 2025 07:46
deleonio
deleonio requested changes May 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@deleonio deleonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anicyne, an sich korrekt, aber jetzt hast du zu viel wieder weggenommen. Lass uns im Daily sprechen.

@anicyne anicyne force-pushed the 7487-fix-drawer-slot-style branch from 2c11bcf to daba8fc Compare May 7, 2025 07:18
deleonio
deleonio previously approved these changes May 7, 2025
View reviewed changes
@deleonio deleonio force-pushed the 7487-fix-drawer-slot-style branch from b6015fa to 524f96e Compare May 7, 2025 08:23
@anicyne anicyne force-pushed the 7487-fix-drawer-slot-style branch from 524f96e to fbd754f Compare May 7, 2025 08:32
@deleonio deleonio mentioned this pull request May 7, 2025
Closed
@anicyne anicyne requested a review from deleonio May 7, 2025 08:58
@deleonio deleonio force-pushed the 7487-fix-drawer-slot-style branch from de04313 to 7cdafaf Compare May 7, 2025 10:07
@deleonio deleonio merged commit e70b30c into release/2 May 7, 2025
8 checks passed
@deleonio deleonio deleted the 7487-fix-drawer-slot-style branch May 7, 2025 10:50
@publicuibot publicuibot bot locked and limited conversation to collaborators May 7, 2025
@deleonio deleonio removed the v2 label Jun 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@deleonio deleonio deleonio approved these changes

+1 more reviewer

@sdvg sdvg sdvg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drawer - Slot muss maximale Höhe bzw. Breite bekommen

3 participants

@anicyne @sdvg @deleonio
⚡